Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CUP disposable missile launchers breaking init after CBA 3.18 update #3409

Conversation

jaj22
Copy link

@jaj22 jaj22 commented Oct 8, 2024

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement
  4. Fuck CBA

What have you changed and why?

A variable used for detecting disposable missile launcher types was changed in CBA 3.18, breaking Antistasi init when CUP weapons is loaded. This PR works around it. Also doesn't break in older CBA, although it won't detect the missiles correctly.

Please specify which Issue this PR Resolves.

closes #XXXX

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

@jaj22 jaj22 added Priority Should be fixed first Bug Something isn't working labels Oct 8, 2024
Copy link

@Bob-Murphy Bob-Murphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested & lgtm

@Bob-Murphy Bob-Murphy added this to the 3.7.1 milestone Oct 8, 2024
@Bob-Murphy Bob-Murphy mentioned this pull request Oct 8, 2024
@Bob-Murphy Bob-Murphy merged commit 0a37c52 into official-antistasi-community:unstable Oct 8, 2024
SilenceIsFatto added a commit to SilenceIsFatto/A3-Antistasi-Ultimate that referenced this pull request Oct 8, 2024
Replicated from Community official-antistasi-community#3409, no point doing it twice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Priority Should be fixed first Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants