Overlapping comparison in syzygy

[atg]

Clang found this.

if (v1 >= 0 || v1 < 100)

which doesn't seem entirely intentional.

[syzygy1]

Correct, it should be "v1 >= 0 || v1 < -100".

This is part of en passant handling. v1 is the DTZ score after the en passant capture, v is the DTZ score of the position assuming no ep is possible (the tables don't store en passant positions). The code then takes the "best" of v and v1 (unless the position without ep is stalemate!).
We are in the case that v indicates a loss (-100 <= v < 0). That means v1 is "better" if it is a draw or (cursed) win (>= 0) or a "cursed(/blessed) loss" (< -100).
If v1 is also a loss, it is never better than v, because the ep capture is a zeroing move so the ep capture loss is never better than any other loss in terms of DTZ. (As you can see from the code, v1 is one of -101,-1,0,1,101. So the condition could also be replaced by "v1 != -1".)

The probing code of my private engine has the same typo / bug.

[mstembera]

@syzygy1 and @lantonov
Could you please confirm Joonas understanding of the patch here?
#415
Thank you!

[syzygy1]

Yes, 100 should be changed to -100:
if (v1 >= 0 || v1 < -100)

[mstembera]

Thank you! But does Joonas explanation of the logic here
#415
make sense?

[syzygy1]

I already gave an explanation on github.

  From: mstembera <notifications@github.com>

To: official-stockfish/Stockfish Stockfish@noreply.github.com
Cc: syzygy1 ronalddeman@yahoo.com
Sent: Sunday, September 6, 2015 1:47 AM
Subject: Re: [Stockfish] Overlapping comparison in syzygy (#394)

Thank you! But does Joonas explanation of the logic here
#415
make sense?—
Reply to this email directly or view it on GitHub.

[lantonov]

Below is the RdM's explanation for "cursed win" and "cursed loss" in syzygy which are indeed connected with the 50-move rule.

"Anyway, this is all not a problem for my tablebases. If the engine wants to ignore the 50-move rule for tablebase positions, it can ignore the 50-move rule when using my tablebases. This is because my tablebases do not store a draw by the 50-move rule as a draw, but as a "cursed win" or "cursed loss". The engine can simply treat "cursed wins" as real wins and "cursed losses" as real losses. Or it can honor the 50-move rule and treat both of them as draws. Or it can bluff and treat cursed wins by the engine as wins and cursed losses as draws."

So, RdM's explanation for what this patch does:

"This is part of en passant handling. v1 is the DTZ score after the en passant capture, v is the DTZ score of the position assuming no ep is possible (the tables don't store en passant positions). The code then takes the "best" of v and v1 (unless the position without ep is stalemate!).
We are in the case that v indicates a loss (-100 <= v < 0). That means v1 is "better" if it is a draw or (cursed) win (>= 0) or a "cursed(/blessed) loss" (< -100)."

is indeed correctly understood by Joona who describes it more clearly.

I wanted to test this patch on the framework but it does not test syzygy at present. Another option is to find positions close to endgame that include en passant moves and test with or w/o syzygy.