-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix validating Master branch in the form. #1732
Fix validating Master branch in the form. #1732
Conversation
added an exception as requested, unfortunately, I'm not able to run black formatter. |
dcfa97b
to
c6679fd
Compare
Formatted, DEV updated. |
it seems to work taking aside the current master net not yet in the backup of dev. |
Ive noticed there will be still an issue with current implementation if we test master vs master I try to keep changes as minimal as possible but neccessity exists.. I will make all regrex the same tomorrow(it's around 1am now). Sorry for the inconvience. |
fe74ec9
to
880fb06
Compare
Nitpicking but if the same regex will be used multiple times (3) can't we store it somewhere once? |
880fb06
to
b73ea49
Compare
You could argue the links should not be redeclared each time |
A config file refactor would be a cool PR for all the code not only here I think we're a bit in a hurry including the fix. |
d3c9d0a
to
e415b30
Compare
e415b30
to
fbb3acb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested fine on DEV
PROD updated, thank you @peregrineshahin :) |
needs testing on dev.