Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validating Master branch in the form. #1732

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

peregrineshahin
Copy link
Contributor

needs testing on dev.

@peregrineshahin
Copy link
Contributor Author

added an exception as requested, unfortunately, I'm not able to run black formatter.

@ppigazzini
Copy link
Collaborator

Formatted, DEV updated.

@peregrineshahin
Copy link
Contributor Author

it seems to work taking aside the current master net not yet in the backup of dev.

@peregrineshahin
Copy link
Contributor Author

Ive noticed there will be still an issue with current implementation if we test master vs master

I try to keep changes as minimal as possible but neccessity exists.. I will make all regrex the same tomorrow(it's around 1am now). Sorry for the inconvience.

@peregrineshahin peregrineshahin force-pushed the fixBench2 branch 4 times, most recently from fe74ec9 to 880fb06 Compare June 15, 2023 05:06
@dav1312
Copy link
Contributor

dav1312 commented Jun 15, 2023

Nitpicking but if the same regex will be used multiple times (3) can't we store it somewhere once?

@peregrineshahin
Copy link
Contributor Author

Nitpicking but if the same regex will be used multiple times (3) can't we store it somewhere once?

You could argue the links should not be redeclared each time
This should be refactored along other places in the code via a config file.

@peregrineshahin
Copy link
Contributor Author

Nitpicking but if the same regex will be used multiple times (3) can't we store it somewhere once?

You could argue the links should not be redeclared each time This should be refactored along other places in the code via a config file.

A config file refactor would be a cool PR for all the code not only here I think we're a bit in a hurry including the fix.

@peregrineshahin peregrineshahin force-pushed the fixBench2 branch 3 times, most recently from d3c9d0a to e415b30 Compare June 16, 2023 17:39
Copy link
Collaborator

@ppigazzini ppigazzini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested fine on DEV

@ppigazzini ppigazzini merged commit 41805e0 into official-stockfish:master Aug 19, 2023
17 checks passed
@ppigazzini
Copy link
Collaborator

PROD updated, thank you @peregrineshahin :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants