Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prov/efa: log hmem iface name instead of enum #10136

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

wenduwan
Copy link
Contributor

Logging improvement

@wenduwan wenduwan requested a review from a team June 28, 2024 19:21
@wenduwan wenduwan marked this pull request as ready for review June 28, 2024 19:21
@wenduwan
Copy link
Contributor Author

Hey @zachdworkin do you know the reason for appveyor failure?

@zachdworkin
Copy link
Contributor

@shijin-aws It doesn't look like appveyor ran anything. There is no job in the history for this PR either. I think it has to do with this: "Appveyor continually checks for branch mergablility for 10 seconds after a PR is opened before running". Since this PR is still checking for ability to merge automatically I suspect that it stopped trying and reported this " AppVeyor was unable to build non-mergeable pull request" failure. I have noticed that github has been lagging recently with things like this so its possible that its just a quirk that needs to get ironed out. I am about to merge an update for Intel CI with #10133. I would rebase to grab those changes and then repush to see if that can trigger appveyor to re-run.

@zachdworkin
Copy link
Contributor

@shijin-aws I just merged it. Can you rebase and try again to re-trigger appveyor? I also aborted your Intel-CI job so that it saves time on our resource since you will repush shortly.

@shijin-aws
Copy link
Contributor

bot:aws:retest

@shijin-aws
Copy link
Contributor

shijin-aws commented Jul 1, 2024

AWS CI failure seems real, but it's not clear to me now how it's related to your change

@shijin-aws
Copy link
Contributor

AWS CI failure seems real, but it's not clear to me now how it's related to your change

Figured out the bug, need to rebase on #10144

Logging improvement

Signed-off-by: Wenduo Wang <wenduwan@amazon.com>
@shijin-aws
Copy link
Contributor

bot:aws:retest

@wenduwan
Copy link
Contributor Author

wenduwan commented Jul 3, 2024

AWS CI passed. Should be good to go.

@shijin-aws shijin-aws merged commit aab4c81 into ofiwg:main Jul 3, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants