prov/efa: Split efa_rdm_ep.inject_size, add support for remaining EP size opts
#10413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijin-aws
reviewed
Sep 25, 2024
| size_t max_tagged_size; /**< #FI_OPT_MAX_TAGGED_SIZE */ | ||
| size_t max_rma_size; /**< #FI_OPT_MAX_RMA_SIZE */ | ||
| size_t max_atomic_size; /**< #FI_OPT_MAX_ATOMIC_SIZE */ | ||
| size_t inject_msg_size; /**< #FI_OPT_INJECT_MSG_SIZE */ |
There was a problem hiding this comment.
I am considering whether we can make it as an array with index as op code.
There was a problem hiding this comment.
This is not a blocking comment though
shijin-aws
approved these changes
Sep 26, 2024
|
bot:aws:retest |
|
Pretty sure MSVC is unhappy |
darrylabbate
force-pushed
the
feat/efa/ep-size-opts
branch
from
4652bbe
to
641af7b
Compare
|
you will need to rebase after #10419 is merged to get Intel CI to pass |
darrylabbate
force-pushed
the
feat/efa/ep-size-opts
branch
2 times, most recently
from
5d2b9f6
to
7dc814a
Compare
Hmm it definitely was |
|
bot:aws:retest |
|
Need to rebase and resolve the merge conflict |
darrylabbate
force-pushed
the
feat/efa/ep-size-opts
branch
2 times, most recently
from
437c13b
to
e1f26a2
Compare
Signed-off-by: Darryl Abbate <drl@amazon.com>
This adds support for FI_OPT_{MSG,INJECT}_{TAGGED,ATOMIC}_SIZE
Signed-off-by: Darryl Abbate <drl@amazon.com>
darrylabbate
force-pushed
the
feat/efa/ep-size-opts
branch
from
e1f26a2
to
8c2b302
Compare
shijin-aws
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.