fabtests/configure, efa: call provider specific configure #10420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should fix Intel CI issue that cannot build efa specific fabtests |
j-xiong
reviewed
Sep 27, 2024
shijin-aws
force-pushed
the
fabtest_efa
branch
from
e181267
to
079676c
Compare
j-xiong
reviewed
Sep 27, 2024
shijin-aws
force-pushed
the
fabtest_efa
branch
from
079676c
to
90875a2
Compare
|
The current Intel CI run looks okay with just this change applied. I will test it in combination with the other one now |
the --enable-efa=no option and these changes both allow fabtests to be built on our node which is missing the package |
|
The build that is failing now is SHMEM middleware. Its not finding stdlib.h... im going to re-run |
shijin-aws
force-pushed
the
fabtest_efa
branch
from
90875a2
to
e34ac10
Compare
aingerson
approved these changes
Sep 27, 2024
j-xiong
approved these changes
Sep 27, 2024
zachdworkin
approved these changes
Sep 27, 2024
Create efa provider's own configure.m4 and make configure.ac call it. Build efa_rdma_checker conditionally when all symbols are available. Signed-off-by: Shi Jin <sjina@amazon.com>
shijin-aws
force-pushed
the
fabtest_efa
branch
from
e34ac10
to
6b359c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create efa provider's own configure.m4 and make configure.ac call it.
Build efa_rdma_checker conditionally when all symbols are available.