prov/cxi: ignore FLT_OVERFLOW and FLT_INVALID errors #10513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't treat CXIP_COLL_RC_FLT_OVERFLOW and CXIP_COLL_RC_FLT_INVALID as errors. Add logging for when one of these two or CXIP_COLL_RC_FLT_INEXACT is encountered. Signed-off-by: John Heemstra <heemstra@hpe.com>
heemstra
force-pushed
the
ignore_ovf_inv
branch
from
185d971
to
8c5c504
Compare
swelch
approved these changes
Nov 1, 2024
|
@j-xiong @shijin-aws - can you comment on these failures? |
|
bot:aws:retest |
|
AWS CI failure is unrelated. can ignore |
|
There is one failed test with mpich over tcp. I don't think it is related. |
heemstra
added a commit
to heemstra/libfabric
that referenced
this pull request
Nov 12, 2024
Update the unit tests for collectives to account for previously-merged PR: ofiwg#10513
heemstra
added a commit
to heemstra/libfabric
that referenced
this pull request
Nov 12, 2024
Update the unit tests for collectives to account for previously-merged PR: ofiwg#10513 Signed-off-by: John Heemstra <heemstra@hpe.com>
iziemba
pushed a commit
that referenced
this pull request
Nov 13, 2024
Update the unit tests for collectives to account for previously-merged PR: #10513 Signed-off-by: John Heemstra <heemstra@hpe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't treat CXIP_COLL_RC_FLT_OVERFLOW and CXIP_COLL_RC_FLT_INVALID as errors. Add logging for when one of these two or CXIP_COLL_RC_FLT_INEXACT is encountered.