prov/efa, fabtests: Implement FI_MORE for fi_recv #10532
+111
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijin-aws
reviewed
Nov 13, 2024
|
|
||
| assert(pke_cnt); | ||
|
|
||
| ep = pke_vec[0]->ep; | ||
| assert(ep); | ||
|
|
||
| wr_index = ep->base_ep.efa_recv_wr_index; | ||
|
|
||
| for (i = 0; i < pke_cnt; ++i) { |
There was a problem hiding this comment.
Another approach may be having efa_rdm_ep_post_internal_rx_pkts call this function in a loop of pkt_cnt times, where the first pkt_cnt-1 times are with FI_MORE. So we can get rid of this loop inside
But this version should be good as well... We can revisit it later if necessary.
shijin-aws
approved these changes
Nov 13, 2024
j-xiong
reviewed
Nov 13, 2024
jiaxiyan
force-pushed
the
write_fi_more
branch
from
1c7d372
to
d6ce2d4
Compare
j-xiong
approved these changes
Nov 13, 2024
jiaxiyan
force-pushed
the
write_fi_more
branch
from
d6ce2d4
to
7e88c5f
Compare
shijin-aws
reviewed
Nov 13, 2024
shijin-aws
reviewed
Nov 13, 2024
jiaxiyan
force-pushed
the
write_fi_more
branch
from
7e88c5f
to
5cec3c4
Compare
jiaxiyan
force-pushed
the
write_fi_more
branch
from
5cec3c4
to
07963e7
Compare
shijin-aws
approved these changes
Nov 13, 2024
|
Some offline discussion shows that this PR will cause issue when both internal rx buffer and user fi_recv calling |
jiaxiyan
force-pushed
the
write_fi_more
branch
2 times, most recently
from
91c10ea
to
0eec1b0
Compare
shijin-aws
reviewed
Nov 14, 2024
Track the last index of wr with recv_wr_index. Append wr when FI_MORE is set. Only post recv when FI_MORE is not set. Signed-off-by: Jessie Yang <jiaxiyan@amazon.com>
Also fix a bug in ft_recvmsg that uses tx_seq tag. Signed-off-by: Jessie Yang <jiaxiyan@amazon.com>
Signed-off-by: Jessie Yang <jiaxiyan@amazon.com>
jiaxiyan
force-pushed
the
write_fi_more
branch
from
0eec1b0
to
0f1eca9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement FI_MORE for fi_recv in zero-copy recv mode.
Allow tests with FI_MORE flag by using fi_recvmsg.
Add FI_MORE pytest for fi_recv in test_rdm_bw_zcpy_recv_use_fi_more.