prov/tcp: introduce TCP_NO_CONNECT flag #10534
Draft
+64
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soumagne
reviewed
Nov 13, 2024
aingerson
reviewed
Nov 13, 2024
soumagne
reviewed
Nov 13, 2024
ooststep
force-pushed
the
tcp-no-connect
branch
from
357d8e3
to
1ed132e
Compare
There are some specific use cases where we may not want one side of communication to initiate connections, namely when we know that one side of our configuration is being heavily restricted by a firewall. To prevent indefinite hangs with certain operations, such as RMA reads and writes, introduce a provider specific flag to trigger an error if there is not already an established connection. In this case, the application can force the connection from the other direction. Signed-off-by: Stephen Oost <stephen.oost@intel.com>
ooststep
force-pushed
the
tcp-no-connect
branch
from
1ed132e
to
d447e69
Compare
j-xiong
reviewed
Nov 14, 2024
| @@ -78,6 +78,11 @@ enum { | |||
| FI_OPT_EFA_WRITE_IN_ORDER_ALIGNED_128_BYTES, /* bool */ | |||
| }; | |||
|
|
|||
| /* provider specific op flags range between 60-63 */ | |||
| enum { | |||
| FI_FLAG_TCP_NO_CONNECT = (1ULL << 60) | |||
There was a problem hiding this comment.
I would remove FLAG from the name.
There was a problem hiding this comment.
Personally, I prefer the flag to be clear about it, similar to how the EP options start with FI_OPT_{PROV}
There was a problem hiding this comment.
FI_OPT_ is a common prefix for options passed to fi_setopt/fi_getopt, but we don't use FI_FLAG_ for other flags.
| : The tcp provider supports the following op flags | ||
|
|
||
| *FI_FLAG_TCP_NO_CONNECT* | ||
| : This flag indicates that operations should fail if there is not an |
| *FI_FLAG_TCP_NO_CONNECT* | ||
| : This flag indicates that operations should fail if there is not an | ||
| existing connection to the remote peer. Instead, if there is not | ||
| an established connection, an FI_ENOTCONN error should be expected. |
There was a problem hiding this comment.
Instead ..... should be expected. --> In such case, an FI_ENOTCONN error should be returned.
| : This flag indicates that operations should fail if there is not an | ||
| existing connection to the remote peer. Instead, if there is not | ||
| an established connection, an FI_ENOTCONN error should be expected. | ||
| If there is an existing connection, the operation can complete normally. |
There was a problem hiding this comment.
The last sentence can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some specific use cases where we may not want one side of communication to initiate connections, namely when we know that one side of our configuration is being heavily restricted by a firewall. To prevent indefinite hangs with certain operations, such as RMA reads and writes, introduce a provider specific flag to trigger an error if there is not already an established connection. In this case, the application can force the connection from the other direction.