prov/xnet: Return an error if invalid sequence number received #9424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If compiled with --enable-debug, the provider would fail an assertion if the sequence number received in the header doesn't match the one expected. Crashing on an assertion failure is fine for programming errors, but the assertion failure described above relies on external events: it may for example trigger because of a buffers corrupted by the TCP stack or the physical layer. Instead of an assertion failure, the function returns an error code, which will cause the EP to be disabled as a consequence. Signed-off-by: Sylvain Didelot <sdidelot@ddn.com>
sydidelot
force-pushed
the
xnet_assert
branch
from
0567242
to
c7a4edd
Compare
shefty
reviewed
Oct 10, 2023
| "Received invalid hdr sequence number\n"); | ||
| return -FI_EIO; | ||
| } | ||
| #endif |
There was a problem hiding this comment.
Do we want to make the id an always on check?
There was a problem hiding this comment.
The problem with making the id an always on check is that it would change the wire protocol: sender is required to set the id, which never happens if debug is disabled.
There was a problem hiding this comment.
That's a good point. It's not worth breaking the protocol for this. I think the provider may be able to negotiate this during connection setup. That may be worthwhile, even if the field is kept as debug only. That might also address Bernard's comment on #7844.
For now, I'm good with this change.
|
Btw, relates to #7844 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If compiled with --enable-debug, the provider would fail an assertion if the sequence number received in the header doesn't match the one expected.
Crashing on an assertion failure is fine for programming errors, but the assertion failure described above relies on external events: it may for example trigger because of a buffers corrupted by the TCP stack or the physical layer.
Instead of an assertion failure, the function returns an error code, which will cause the EP to be disabled as a consequence.