prov/util: Fix revert PR #9377 to revert correct lock #9468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aingerson
reviewed
Oct 23, 2023
There was a problem hiding this comment.
Changes are good, but can you put into two separate patches to describe each one? I think in the util ep one you can also remove the comment you added that says to optimize it. Also typo in the commit message if you want to fix while you're at it (revers->reverts)
a-szegel
force-pushed
the
fix-revert-of-ofi-genlock
branch
from
d091fd4
to
b837d36
Compare
a-szegel
changed the title
aingerson
reviewed
Oct 24, 2023
I mistakenly reverted ep->lock to always be an ofi_mutex. Restore ep->lock to depend on domain threading model Signed-off-by: Seth Zegelstein <szegel@amazon.com>
util_cntr->ep_list_lock needs to always be a mutex lock to allow msg endpoints to have a control thread, and claim FI_THREAD_DOMAIN. Signed-off-by: Seth Zegelstein <szegel@amazon.com>
a-szegel
force-pushed
the
fix-revert-of-ofi-genlock
branch
from
b837d36
to
eeedd9e
Compare
aingerson
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mistakenly reverted the wrong lock on #9377, and caused a performance regression. This change makes the ep->lock be domain dependent, and properly reverts util_cntr ep_list_lock to always be mutex. This restores most of the performance regression.