Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Serde support behind feature flag #5

Merged
merged 5 commits into from
Aug 29, 2024

Conversation

zheylmun
Copy link
Contributor

Hello! Thanks for putting together such a fantastic library. I'm doing some experimental work on improved tooling for underwater cave survey, and Jord does much of what I need other than serializing data types. I added serialization for each struct and enum, and the changes are behind a serde feature flag, so there are no additional dependencies unless someone enables the feature.
Additionally I did switch the crate level lint from forbid to deny. Forbid was giving a false positive for unused crates, and is being replaced anyways:
rust-lang/rust#81670

@ofmooseandmen
Copy link
Owner

Thanks for your pull request, I'll review it and merge it asap!

Copy link

codecov bot commented Apr 2, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@zheylmun
Copy link
Contributor Author

@ofmooseandmen , Please let me know if there is anything else you would like me to do for this guy, it wasn't apparent to me how to get it to ignore the derive lines for code coverage, but I can try to figure that out.

@ofmooseandmen
Copy link
Owner

@zheylmun, sorry I was quite busy lately, if you could find a way to get the code coverage that would be great. Otherwise, I'll merge by-passing the checks.

@zheylmun
Copy link
Contributor Author

zheylmun commented Jul 26, 2024

As soon as I said this I found a way to do it with comments

@zheylmun zheylmun force-pushed the feature/serde_support branch from 46ccfc4 to 5ffc83d Compare July 26, 2024 00:17
@ofmooseandmen
Copy link
Owner

@zheylmun, you'll need to run the formatter (clippy is not happy...)

@zheylmun
Copy link
Contributor Author

@ofmooseandmen, I manually ran all of the CI commands and think this is good to go, but lemme know if you'd like anything else changed

@ofmooseandmen
Copy link
Owner

Thanks @zheylmun for your contribution and sorry it took me so long to merge

@ofmooseandmen ofmooseandmen merged commit a1b9d5e into ofmooseandmen:main Aug 29, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants