Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some equihash coins #29

Merged
merged 5 commits into from
Apr 20, 2018
Merged

Add some equihash coins #29

merged 5 commits into from
Apr 20, 2018

Conversation

hellcatz
Copy link

No description provided.

Add votecoin, zencash, zclassic, zcash, snowgem, hush, bitcoinprivate, bitcoinz, komodo
@ognus
Copy link
Owner

ognus commented Apr 18, 2018

@hellcatz thanks a lot for the PR :) Do you plan to add some tests for the bunch of coins you've added, please let me know. If not I will try to add them later 👍

@hellcatz
Copy link
Author

I'll look into adding addresses for these coins to the tests. 👍

Add tests for VOTE, BTCZ, ZCl, HUSH, ZEC, BTCP, SNG, ZEN, KMD
Add equihash coins to browser files
Added invalid tests for equihash coins
@hellcatz
Copy link
Author

Updated browser files, tests now passing.
For invalid test, I modified 1 character in a valid address and perform the commonTests
@ognus Please check, looks like all tests are now passing 👍

@ognus
Copy link
Owner

ognus commented Apr 20, 2018

@hellcatz amazing work 🥇 thank you 👍

@ognus ognus merged commit cf845c6 into ognus:master Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants