Allow creation of multiple COMLibrary instances
#69
Conversation
| match instance.init_security() { | ||
| Ok(()) => {} | ||
| // Security was already initialized, this is fine | ||
| Err(WMIError::HResultError { hres }) if hres == RPC_E_TOO_LATE.0 => {} |
There was a problem hiding this comment.
Having to access the i32 representation of the HRESULT with .0 seems a bit off to me.
Can we change the type of hres to HRESULT?
There was a problem hiding this comment.
I agree, but that will be a breaking change so I wanted to avoid that for now.
| match instance.init_security() { | ||
| Ok(()) => {} | ||
| // Security was already initialized, this is fine | ||
| Err(WMIError::HResultError { hres }) if hres == RPC_E_TOO_LATE.0 => {} |
There was a problem hiding this comment.
I agree, but that will be a breaking change so I wanted to avoid that for now.
|
Quick question: I realized during development, that formatting is not enforced (I had several local changes that were due to the fact that my editor automatically formats on save). Additionally, the same could be done for |
This fixes #37 where the relevant discussion can be found.
The second commit adds an example for how to use
COMLibraryas a per-thread singleton, since this should still be the recommended way of using it.