Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo fmt and cargo clippy to CI #70

Merged
merged 8 commits into from
Mar 20, 2023

Conversation

FantasyTeddy
Copy link
Contributor

@FantasyTeddy FantasyTeddy commented Mar 19, 2023

The following changes were made to the CI script:

  • Rename the script to check since test does not properly reflect its role.
  • Split the jobs for building and testing
  • Add the cargo fmt check
    • Ran cargo fmt on the entire project to pass this check
  • Add the cargo clippy check
    • Fix the following warning in datetime.rs:

      use of deprecated associated function chrono::FixedOffset::east: use east_opt() instead

  • Replace actions from the unmaintained action-rs organization

@ohadravid
Copy link
Owner

Nice! Thanks for working on this 😄

@ohadravid ohadravid merged commit 1be8ef2 into ohadravid:main Mar 20, 2023
@FantasyTeddy FantasyTeddy deleted the improve-ci branch March 20, 2023 11:20
@FantasyTeddy
Copy link
Contributor Author

Thanks for merging 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants