Simulator memory pool per instance #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will also cleanup the way we implement memory pools by having the same implementation for the firmware and simulator.
For some reason not really understood, thread_local storage will crash when arch is set to nocona. Nehalem, which is the one used in vcv rack sdk, happens to be alright, so we use that.
ohmtech-rdi
force-pushed
the
simulator-memory-pool-per-instance
branch
from
68585c7 to
157d457
Compare
|
We found out that it is not possible to debug on macOS with VS Code, but the problem was at least not introduced in this branch.
|
|
First time we executed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a flaw where the SRAM and SDRAM simulation was entire to the full process, including in the simulator.
This was mainly motivated because
operator newis a global function, and passing a memory pool around makes a plug-in porting effort way harder.This was not an issue in the firmware, as anyway "there is only one module running at a time", but that's not the case for the simulator.
Because the memory pool is
static, it is shared between multiple instances of the same module, for example on macOS (this depends on the way dynamic libraries are handled).This PR makes it so that there is one memory pool per instance of module in the simulator. The implementation keeps a pointer to know which instance is the "current one". Because there can be multiple instances running in different threads, a thread local storage is used for that.
This is ugly, but seems to work.
Todo: