Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vcv rack sdk 2.4.0 #629

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Vcv rack sdk 2.4.0 #629

merged 4 commits into from
Dec 7, 2023

Conversation

ohmtech-rdi
Copy link
Owner

@ohmtech-rdi ohmtech-rdi commented Nov 19, 2023

This PR updates the vcv-rack-sdk submodule to version 2.4.0 since this version introduces a breaking change in the way plug-ins are loaded, and in particular their path. It also now supports the ARM64 architecture, and fixes a bug in the action system where the Windows binary was not installed.

Todo

  • Check on macOS x86_64
  • Check on macOS arm64

@ohmtech-rdi ohmtech-rdi added the enhancement New feature or request label Nov 19, 2023
@ohmtech-rdi ohmtech-rdi self-assigned this Nov 19, 2023
@ohmtech-rdi ohmtech-rdi force-pushed the vcv-rack-sdk-2.4.0 branch 2 times, most recently from 3b85657 to 041e8dc Compare November 19, 2023 22:51
@ohmtech-rdi
Copy link
Owner Author

ohmtech-rdi commented Nov 19, 2023

That doesn't work on M1 yet, because code signing is mandatory with M1.
We need to:

  • Add ad-hoc code signing support in Xcode,
  • Add ad-hoc code signing support to erbb build simulator.

Unfortunately we can't test automatically on CI using GitHub and their macos-13-xlarge which runs on M1, as those runners are not yet available for public projects.

The VCV Rack sdk version is now 2.4.0 which supports arm64 but also
has a breaking change for plug-ins paths.
@ohmtech-rdi ohmtech-rdi force-pushed the vcv-rack-sdk-2.4.0 branch 2 times, most recently from 519e068 to 956dcce Compare December 7, 2023 19:13
@ohmtech-rdi ohmtech-rdi marked this pull request as ready for review December 7, 2023 19:24
@ohmtech-rdi ohmtech-rdi merged commit 79a695f into main Dec 7, 2023
21 checks passed
@ohmtech-rdi ohmtech-rdi deleted the vcv-rack-sdk-2.4.0 branch December 7, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant