Erbui guitar pedal base support #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows at least what to look for when editing the kicad_pcb file manually.
This also adds implicitly height and 2.5d support with sides concept.
ohmtech-rdi
force-pushed
the
erbui-guitar-pedal-base-support
branch
from
acaf7a8 to
20858dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds base support for making guitar pedals with ERB:
formatkeyword to define the format eg.3ufor1590bb2_portraitFor now though, there are no example on how to use the feature. Those will come as a custom board example, but we need a specific Daisy board to become publicly available first.