Erbui manufacturer control args #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arg keyword will now be used outside of generator definitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves control options such as the number of positions or the display width and height to the manufacturer control definition using the
argsyntax, rather than relying on KiCad parts symbol fields to do so.It is a bit better, because those options could potentially not be related to the part for some reason (though, that's always the case for now),
This is preparation work for some Encoder options, as the current system makes editing a bit more complex, and is also prone to errors, since the options are hidden somewhere in a component in one of the parts of a control.
We will use it also to replace the current
classfor the simulator, which is a bit weird as well.