lib/omb-prompt-base: Set a timeout on git commands #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nntoan
added
bug-fix
nntoan
changed the title
akinomyoga
changed the title
|
rebased. |
The calculate of git_summary_status can be extremely expensive for
large repos. This results in the shell becoming unresponsive.
We now set a timeout of 0.2 seconds to make sure we always have a
responsive shell.
* lib/omb-prompt-base: Set a timeout on git commands
* lib/omb-prompt-base: Fix timeout bug
* lib/omb-prompt-base: Rename function "{run_with => _omb_prompt}_timeout"
* lib/omb-prompt-base(_omb_prompt_timeout): Fix coding style
* lib/omb-prompt-base(_omb_prompt_timeout): Check timeout commands on startup
Fixes ohmybash#172
Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
|
Added fixes and squashed. |
|
@pokowaka @HanJoHibender Do you have any thoughts on this? I now think the default timeout 0.2 sec might be too short. If the timeout is too short, the prompt information will not be shown in many repositories. In fact, a user who picked this commit has increased the timeout to 1 sec: @ghostrider-reborn Maybe you also have a comment? But still, there might be cases where Git information is wanted even if it takes time to show the prompt. Another approach is to get the Git information asynchronously as I mentioned in #172 (comment). |
|
As suggested in #6, another approach is to allow the user to disable the git prompt information for each repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calculate of git_summary_status can be extremely expensive for large
repos. This results in the shell becoming unresponsive.
We now set a timeout of 0.2 seconds to make sure we always have
a responsive shell.
Fixes #172