add ab+simple theme, tested on termux #195
Conversation
|
am i missing anything? why couldn't this be merged yet?? 😭 |
Just remove the notice following the below discussion: > ohmybash#194 (comment) > > i read you don't want new themes. and adding plugins is > complicated. plus, i probably added way more than necessary, > anyway. but it works for me. by @cauerego > > ohmybash#194 (comment) > > The words there is a lie, I do recommend new theme pushed to the > repository, please feel free to do that! by @nntoan
|
|
Could you also check the paragraph in the upcoming change 1f63760 in |
|
i literally can't thank you enough for this review, @akinomyoga 🥺 at least not this year! 🤣 i am too rusty on programming, as it is evident by my noobish tab mistakes, and i still couldn't get myself a good environment to work properly with all this, without a desktop (all devices i have today are mobile phones, either with android or ubuntu touch, which is almost not ubuntu)... really sorry. 😔 on top of that, i haven't been using any shell in a long while and, last few times i did, the git plugin turned out to slow it down tremendously... so i was even considering to look for another shell. if i can give you anything today, i hope this might cheer you up: ahoxus.org/achoz being developed with me by @kcubeterm using the only license that should ever be used agpl3+ |
There was a problem hiding this comment.
still couldn't thank you enough for this review...
but i hope at least going through all points as much as i could today is a beginning!
today i just wanted to go over this to remove an annoying "which is deprecated" warning on termux.
but i noticed it was actually related to check_for_upgrade.sh and changed it in my end to use command -v instead.
perhaps next time.
i think i will have other focuses this year.
cheers!
|
here i come again... just removed my conflict caused by my outdated copy of original source (on the "which" issue). working now to prevent this on the next time! |
|
Thanks. It seems there are still some points that have not yet been addressed, but I'll look at them later. |
|
There are still many problems, so I decided to directly edit this PR. |
|
rebased |
akinomyoga
force-pushed
the
master
branch
2 times, most recently
from
569b169 to
1c9f187
Compare
|
Squashed and removed extra images. |
akinomyoga
force-pushed
the
master
branch
2 times, most recently
from
9dbf7ce to
74f10ca
Compare
|
I have also updated the description of the theme 347a077 |
* themes/absimple/amsimple.theme.sh: Update description * themes/absimple/README: Update description
* plugins/bash-preexec: Add loader * plugins/bash-preexec/README: Fix description
|
We need to add README for the xterm plugin. I'll later do that. |
* plugins/xterm: Add header line as an OMB plugin
* plugins/xterm: Add link to the upstream version
* plugins/xterm: Add the list of the configuration variables
* plugins/xterm: Do not rely on the function "cite"
* plugins/xterm: Add dependency to bash-preexec
* plugins/xterm: Use "function func" to avoid aliasing
* plugins/xterm: Namespacing function names
* plugins/xterm: Namespacing configuration variables
* plugins/xterm (_omb_plugin_xterm_set_title): Avoid expanding escapes in directory names, etc.
* plugins/xterm: Always enable precmd/preexec because the plugin should be enabled by the users' decision
* plugins/xterm: Do no unneccessarily add braces around ${var}
* plugins/xterm: Do no uneccessarily quote words
* plugins/xterm: Add README
|
I have added README.md for the xterm plugin. |
|
Thanks, I have finally merged it. |
this is basically a simpler and short version of powerline, with date and time and support for titled sessions in termux.
to keep it short and fun, date only shows randomly. true random (rather than pseudo).
the plugins are only added to support the titling.