Update CONTRIBUTING.md #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just remove the notice following the below discussion: > ohmybash#194 (comment) > > i read you don't want new themes. and adding plugins is > complicated. plus, i probably added way more than necessary, > anyway. but it works for me. by @cauerego > > ohmybash#194 (comment) > > The words there is a lie, I do recommend new theme pushed to the > repository, please feel free to do that! by @nntoan
akinomyoga
force-pushed
the
update-contributing
branch
from
5e54176 to
fdbe9d3
Compare
akinomyoga
force-pushed
the
update-contributing
branch
2 times, most recently
from
e23603a to
80dfb5d
Compare
> ohmybash#268 (reply in thread) > > Just keep in mind we need all PRs to be POSIX-compatible unless > they're creating a plugin that clearly mention working only with > macOS for e.g by @nntoan
akinomyoga
force-pushed
the
update-contributing
branch
from
80dfb5d to
1f63760
Compare
|
I will consider #90 after settling this PR. |
|
It seems there is no reply for this PR, but there are several awaiting changes. Also, this is just a document so does not affect the behavior. I will merge this PR now, but if you have any additional comments, feel free to create a new issue or PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oh-my-bashfollowing the comment by @nntoan.