Do not overwrite backup bashrc #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinomyoga
force-pushed
the
do-not-overwrite-backup-bashrc
branch
from
a5bdefb to
4d01b2f
Compare
Closed
The code is originated from the uninstallation script for ohmyzsh, which switches the default shell from Bash to Zsh in its installation. Oh-my-bash does not change the default shell in its installation, so there is no need to change it back to /bin/bash in the uninstallation.
Co-authored-by: Alexandre Alessi <alexpfba@gmail.com>
akinomyoga
force-pushed
the
do-not-overwrite-backup-bashrc
branch
from
4d01b2f to
1543bc9
Compare
This was referenced Jan 12, 2022
|
This new version should be released, since all distributions still have the old 7.1.0 version, and hence this mindlessly damaging overwrite without notice or backup of .bashrc is still affecting everyone who is downloading the latest release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue reported at #115 and #267. We should not overwrite the existing backup file. In this PR, I take the approach suggested by @alexpfx in #115; The backup filename now contains the timestamp. Also, in recovering the original bashrc, we search for the latest backed-up
.bashrcthat does not containsource oh-my-bash.sh. Additionally, the code ofchsh -s bashin uninstallation, which makes sense only foroh-my-zsh, has been removed.Resolve #267 / Resolve #115