Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Quoting #432

Merged
merged 5 commits into from
May 14, 2023
Merged

fix: Quoting #432

merged 5 commits into from
May 14, 2023

Conversation

hyperupcall
Copy link
Contributor

@hyperupcall hyperupcall commented Apr 7, 2023

Improve quoting in various areas.

I also had the chance to reproduce #242, but it seems like the issue has been fixed since then. So closes #242

Copy link
Contributor

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I have comments as follows.

completions/django.completion.sh Outdated Show resolved Hide resolved
lib/omb-prompt-base.sh Outdated Show resolved Hide resolved
themes/agnoster/agnoster.theme.sh Outdated Show resolved Hide resolved
tools/git-prompt.sh Outdated Show resolved Hide resolved
@akinomyoga akinomyoga force-pushed the quoting branch 4 times, most recently from a6498e8 to ca98583 Compare April 16, 2023 08:09
@akinomyoga
Copy link
Contributor

Updated commit messages for Conventional Commits.

@hyperupcall
Copy link
Contributor Author

hyperupcall commented Apr 17, 2023

I'm not sure what other improvements I could add, but it looks good to me. It's probably not as productive to fix the completions because it is better to do so upstream - it would be nice if these sort of issues could be autofixed, but I don't think there currently exists a tool to do that (in my opinion ShellCheck doesn't do a very good job of that)

@akinomyoga akinomyoga merged commit dd7807f into ohmybash:master May 14, 2023
@hyperupcall hyperupcall deleted the quoting branch May 19, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with $HOME directory
2 participants