-
-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Quoting #432
fix: Quoting #432
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I have comments as follows.
a6498e8
to
ca98583
Compare
Co-authored-by: Koichi Muarse <myoga.murase@gmail.com>
Updated commit messages for Conventional Commits. |
I'm not sure what other improvements I could add, but it looks good to me. It's probably not as productive to fix the completions because it is better to do so upstream - it would be nice if these sort of issues could be autofixed, but I don't think there currently exists a tool to do that (in my opinion ShellCheck doesn't do a very good job of that) |
Improve quoting in various areas.
I also had the chance to reproduce #242, but it seems like the issue has been fixed since then. So closes #242