Add new Powerline Light theme #436
Conversation
|
Thank you for your contribution! Could you make the image smaller? The image will be used in themes/THEMES.md and the wiki page, where images typically have a size of around 700x290. Also, please update |
Thanks for quick reply - done. Please let me know if OK. |
|
OK |
akinomyoga
force-pushed
the
powerline-light-theme
branch
from
f6b1ea5 to
45d3bb4
Compare
There was a problem hiding this comment.
A powerline-based theme is supposed to source powerline/powerline.base.sh and then define its own functions. The base.sh of the new theme seems to be the same as powerline/powerline.base.sh, so I have removed the file and changed powerline-light.theme.sh to directly source powerline/powerline.base.sh (f6b1ea5).
I now tried the theme. It seems the color of error exit statuses seems to be now dark cyan. However, we usually expect warning colors for failures. Could you update the color of the error exit statuses?
|
Error exit status now a shade of red/orange (which is much more logical). Screenshot now a bit larger, previously a bit too small. |
Thank you!
Now the image is too large; the height is 373px. Could you prepare a smaller image of the height around 290px? You can crop the image instead of reducing the resolution. The display background and the terminal frame are irrelevant to the OMB theme. |
|
Okay, I think it should be ready now. |
akinomyoga
force-pushed
the
powerline-light-theme
branch
from
68ccc65 to
a2266b4
Compare
Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
akinomyoga
force-pushed
the
powerline-light-theme
branch
from
a2266b4 to
a5020a3
Compare
The regular Powerline theme is good... if you have a dark background in your Terminal ;)
If you use a light background such as "black on light yellow" or Solarized Light, then this theme is for you.
Tweak are done in themes/powerline-light/powerline-light.theme.sh used this colour chart as a reference: https://github.com/gawin/bash-colors-256