omb-prompt-base: do not attempt to process git vars outside a git tree #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinomyoga
force-pushed
the
jjm/early-exit-git-prompt-vars
branch
2 times, most recently
from
27a9e7a to
a9cd9f1
Compare
Signed-off-by: Joe MacDonald <joe.macdonald@siemens.com> Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
akinomyoga
force-pushed
the
jjm/early-exit-git-prompt-vars
branch
from
a9cd9f1 to
3e9c127
Compare
akinomyoga
approved these changes
May 23, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this when checking out the n0qorg, being outside a git repository would have an undecorated
detached:(fromSCM_THEME_DETACHED_PREFIX) in the prompt. It's easy enough to correct this in the theme but since the problem also may be observed in hawaii50, iterate, pro, standard and zitron as well, andgit rev-parseis fast to execute anyway, this seems to be the correct place to insert this quick check.