This repository has been archived by the owner on Jul 16, 2019. It is now read-only.
JENKINS-26907 issue at https://issues.jenkins-ci.org/browse/JENKINS-26907 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed required jenkins core to 1.399
[bugfix] tags not stored into the configuration file.
Add environment variable expansion for tags
useAppVersionURL parameter to use upload new version URL
that the plugin describe all the file types that can be uploaded in the 'ipa' and 'dsym' fields of the HockeyApp 'Upload New Versions' API. http://support.hockeyapp.net/kb/api/api-upload-new-versions ipa - optional (required, if dsym is not specified for iOS or Mac), file data of the .ipa for iOS, .app.zip for Mac OS X, or .apk file for Android dsym - optional, file data of the .dSYM.zip file (iOS and Mac) or mapping.txt (Android) see also this discussion: http://support.hockeyapp.net/discussions/questions/1538-jenkins-ci-is-there-an-upload-apiplugin-for-macos-apps
change the labels and documentation around 'ipa' and 'dsym' plugin fields
For example, when the 'useAppVersionURL' field was added, people upgrading the plugin would start a build, the plugin would try to dereference its auto-unboxed values, which would be null, causing a NPE. Also cleaned up unnecessary getter methods.
Crash fix plus various improvements
* Retrofit tests * Tidy up code a bit * Remove pointless null checks * Use Jenkins.getInstance as Hudson.getIntance is deprecated * Use try-with-resources where possible * Minor code style fixes
* Add symbols to extension points * Remove annotation-indexer Seems to cause problems with this included and no problems without. Strange..... Can't see where this is used so removing for now. * Bump structs to 1.13 Note: 1.14+ requires that we bump the minimum supported Jenkins version for this plugin. Remove structs test dependency This is taken care of with the compile dependency of the same plugin.
* [JENKINS-51982] Do not create install URL If public_url not available typically because we are using an API key that has insufficient permissions to create releases. * Autoformat class * Enrich mock response for app upload * Auto reformat class * Calculate appVersion from configUrl Using id can cause issues when the UploadApp method is used as the id is static and points to the id of the app rather than the version which is what we want. * Add tests for build actions
In scope of JENKINS-33310
* Concerning JENKINS-22657 : Minimum, non-framework related fix to make the HockeyApp plugin respect proxy exception settings * Fixed the use of the proxy settings and add debug loggings on which proxy settings are found and used * Use a proxy configuration only if needed The Jenkins configuration may optionally define a list of no proxy hosts in which case we should not attempt to use a proxied connection.
* Add support for uploading multiple builds to the same version * Remove HttpMethod enum, move HttpInfo to its own class, add unit test * Add an overloaded constructor for VersionCreation, copy change
* Rearrange maintainers in order of newest first * Update description to alphabetical order or artefacts
* Adding ability to get changelogs for Multibranch Pipeline * Update to allow for empty changesets in multibranch pipelines * Bump dependency versions * Format code * Remove classifier tag for dependency * Default to Java 8 * Bump parent parent pom version * Bump min Jenkins version -> 2.73.3 * Update dependencies to latest where available and that will not force another Jenkins bump.
* Add Nullable annotation to versionCode * Remove up unused code * Move versionCode to optional DataBoundSetter * Make appId NonNull * Use CheckForNull for versionCode Taken from https://jenkins.io/doc/developer/plugin-development/pipeline-integration/#constructor-vs-setters * Remove redundant null check appId is always NonNull. * Add deprecated constructor Needed to prevent further breakages as others (such as test classes) may need it. * Rename upload version string constant * Add inline comments * Update tests for version creation
* Autoformat global jelly file * Reword help message for default token * Add globalDebugMode and timeout help files * Add check for incorrect timeout entry * Explicitly depend on Apache Commons Lang 3 Rather than on a bundled dependency from another dependency.
* Reword the plugin text * Remove unused throws * Correct spelling mistakes * Simplify return expression * Remove unused import * Remove redundant if branch * Add NonNull annotations to overridden methods * Remove constant conditions that are always true * Migrate applicable code to Java 8 * Specify default content type * Rename constant * Add default character set to method * Add final modifier * Change return value * Remove unused throws * Convert wrapper to primitive * Ensure baseUrl is never null * Deprecate old constructor * Deprecate old constructor Prefer @DataBoundSetters * Update help text in advance configuration * Revert "Ensure baseUrl is never null" This reverts commit e051f64 * Vvalidate custom base urls * Remove static modifier from private methods * Autoformat class * Ensure baseUrl is defaulted if not supplied Remove it from the pipeline syntax if not supplied. * Make getters public * Refactor Configuration tests * Rename test methods * Remove HockeyappRecorderBuilder * Refactor unit tests to use given when then syntax * Autoformat test class * Rename class and test methods * Fix or suppress warnings * Add Given When Then comments for tests * Update pipeline tests removing baseUrlHolder * Add compatibility text to installed plugins snippet
* Bump version to 1.5.0 Breaking changes. * Deprecate String usage in favour of Secret for tokens * Add compatible since attribute
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested fix in file https://github.com/jenkinsci/hockeyapp-plugin/blob/master/src/main/java/hockeyapp/HockeyappRecorderConverter.java
[code]
private long unmarshalPluginVersion(HierarchicalStreamReader reader) {
final String versionString = reader.getAttribute("schemaVersion");
return versionString == null ? 0L : Long.parseLong(versionString);
}
[/code]
to
[code]
private long unmarshalPluginVersion(HierarchicalStreamReader reader) {
String versionString = reader.getAttribute("schemaVersion");
if (versionString == null) {
while (reader.hasMoreChildren()) {
reader.moveDown();
if (reader.getNodeName() == "schemaVersion") {
versionString = reader.getValue();
}
reader.moveUp();
}
}
return versionString == null ? 0L : Long.parseLong(versionString);
}
[/code]