Use ExplicitImplicitTypes.symbolReplacements instead of ExplicitResul…

…tTypes.symbolReplacements
ohze · Jun 24, 2020 · c3b2bc0 · c3b2bc0
1 parent 5198283
commit c3b2bc0
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 13 deletions.
diff --git a/README.md b/README.md
@@ -66,18 +66,13 @@ ExplicitResultTypes {
 => Add type to implicit members of `class`es, `trait`s
 
 2. And this rule
-```diff
+```hocon
 rules = [
-  ExplicitResultTypes
-+  "github:ohze/scalafix-rules/ExplicitImplicitTypes"
+  "github:ohze/scalafix-rules/ExplicitImplicitTypes"
 ]
-ExplicitResultTypes {
-  memberVisibility = [] # only rewrite implicit members
-  skipSimpleDefinitions = []
-+  # maybe need
-+  symbolReplacements {
-+    "scala/concurrent/ExecutionContextExecutor#" = "scala/concurrent/ExecutionContext#"
-+  }
+# maybe need
+ExplicitImplicitTypes.symbolReplacements {
+  "scala/concurrent/ExecutionContextExecutor#" = "scala/concurrent/ExecutionContext#"
 }
 ```
 => Add type to implicit local `def/val/var`s

diff --git a/scalafix/input/src/main/scala/fix/ExplicitImplicitTypesTest.scala b/scalafix/input/src/main/scala/fix/ExplicitImplicitTypesTest.scala
@@ -1,6 +1,6 @@
 /*
 rule = ExplicitImplicitTypes
-ExplicitResultTypes.symbolReplacements {
+ExplicitImplicitTypes.symbolReplacements {
   "scala/concurrent/ExecutionContextExecutor#" = "scala/concurrent/ExecutionContext#"
 }
 */

diff --git a/scalafix/rules/src/main/scala/fix/ExplicitImplicitTypes.scala b/scalafix/rules/src/main/scala/fix/ExplicitImplicitTypes.scala
@@ -21,7 +21,7 @@ final class ExplicitImplicitTypes(global: LazyValue[ScalafixGlobal]) extends Sem
 
   override def withConfiguration(config: Configuration) = {
     val symbolReplacements =
-      config.conf.dynamic.ExplicitResultTypes.symbolReplacements
+      config.conf.dynamic.ExplicitImplicitTypes.symbolReplacements
         .as[Map[String, String]]
         .getOrElse(Map.empty)
 

diff --git a/scalafix/rules/src/main/scala/fix/ExplicitImplicitTypesImpl.scala b/scalafix/rules/src/main/scala/fix/ExplicitImplicitTypesImpl.scala
@@ -21,7 +21,7 @@ final class ExplicitImplicitTypesImpl(global: LazyValue[ScalafixGlobal]) extends
 
   override def withConfiguration(config: Configuration) = {
     val symbolReplacements =
-      config.conf.dynamic.ExplicitResultTypes.symbolReplacements
+      config.conf.dynamic.ExplicitImplicitTypes.symbolReplacements
         .as[Map[String, String]]
         .getOrElse(Map.empty)