Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLT-4245] TAT trend report legend for Color by Gate #228

Merged
merged 3 commits into from
Sep 17, 2024
Merged

[GLT-4245] TAT trend report legend for Color by Gate #228

merged 3 commits into from
Sep 17, 2024

Conversation

wuall826
Copy link
Contributor

@wuall826 wuall826 commented Aug 22, 2024 •
edited
Loading

Jira ticket or GitHub issue:

  • Includes a change file
  • Updated tests (or n/a)
  • Updated documentation (or n/a)
  • Discussed with CGI (or n/a; see release procedure on wiki for applicability)

grapigeau
grapigeau reviewed Aug 22, 2024
View reviewed changes
ts/component/legend.ts Outdated Show resolved Hide resolved
djcooke
djcooke reviewed Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@djcooke djcooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The legend appears/disappears as intended, but this error is also showing up every time I click the Legend button:
image

changes/add_GLT-4245 Outdated Show resolved Hide resolved
src/main/resources/templates/tat-trend.html Outdated Show resolved Hide resolved
src/main/resources/templates/tat-trend.html Outdated Show resolved Hide resolved
ts/component/legend.ts Outdated Show resolved Hide resolved
ts/component/legend.ts Outdated Show resolved Hide resolved
ts/component/legend.ts Outdated Show resolved Hide resolved
djcooke
djcooke reviewed Sep 11, 2024
View reviewed changes
changes/fix_GLT-4245 Outdated Show resolved Hide resolved
src/main/resources/templates/tat-trend.html Outdated Show resolved Hide resolved
ts/tat-trend.ts Outdated Show resolved Hide resolved
@wuall826 wuall826 merged commit 4c9044a into main Sep 17, 2024
5 checks passed
@wuall826 wuall826 deleted the GLT-4245_tatColorLegend branch September 17, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djcooke djcooke djcooke approved these changes

@grapigeau grapigeau grapigeau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wuall826 @djcooke @grapigeau