Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error when no avatar #69

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

rbourgeat
Copy link

@rbourgeat rbourgeat commented Sep 4, 2024

This code ensures that if avatar_url is None, an empty string is used instead.

fix this issue #68

@rbourgeat rbourgeat changed the title #68 Fix build error when no avatar Fix build error when no avatar Sep 4, 2024
@ojacques
Copy link
Owner

ojacques commented Oct 3, 2024

Hadn't had the case. Nice to see it is now more robust. Thanks!

@ojacques ojacques merged commit 812deea into ojacques:master Oct 3, 2024
j3soon added a commit to j3soon/mkdocs-git-committers-plugin-2 that referenced this pull request Oct 4, 2024
Error message:

        'avatar': commit['author']['avatar_url'] if user['avatar_url'] is not None else ''
    UnboundLocalError: local variable 'user' referenced before assignment

Ref: ojacques#69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants