Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The HSTS directive is always set even in non ssl case #8

Closed
ojullien opened this issue Apr 27, 2019 · 2 comments
Closed

The HSTS directive is always set even in non ssl case #8

ojullien opened this issue Apr 27, 2019 · 2 comments
Assignees
@ojullien
Labels
bug Something isn't working invalid This doesn't seem right
Milestone
v1.3.x

Comments

@ojullien
Copy link
Owner

The HTTP Strict Transport Security directives should not be in the server conf but in the ssl vhost.
@ojullien ojullien added the bug Something isn't working label Apr 27, 2019
@ojullien ojullien added this to the v1.3.x milestone Apr 27, 2019
@ojullien ojullien self-assigned this Apr 27, 2019
ojullien added a commit that referenced this issue Apr 27, 2019
@ojullien
fixed issue #8
95324fe 
Signed-off-by: ojullien <ojullien@users.noreply.github.com>
@ojullien ojullien mentioned this issue Apr 27, 2019
Merged
ojullien added a commit that referenced this issue Apr 27, 2019
@ojullien
Issues #7, #8 and improvement (#9)
2f9f7f2 
* Forwarding information to backend systems

Signed-off-by: ojullien <ojullien@users.noreply.github.com>

* Fixes issue #5

Fixes issue #5

* fixed issue #7

Signed-off-by: ojullien <ojullien@users.noreply.github.com>

* fixed issue #8

Signed-off-by: ojullien <ojullien@users.noreply.github.com>

* reverseproxy refactoring

Signed-off-by: ojullien <ojullien@users.noreply.github.com>

* reverseproxy refactoring

Signed-off-by: ojullien <ojullien@users.noreply.github.com>

* reverseproxy refactoring

Signed-off-by: ojullien <ojullien@users.noreply.github.com>
ojullien added a commit that referenced this issue Aug 8, 2019
@ojullien
Proxy directives (#10)
941d21c 
* Forwarding information to backend systems

Signed-off-by: ojullien <ojullien@users.noreply.github.com>

* Fixes issue #5

Fixes issue #5

* fixed issue #7

Signed-off-by: ojullien <ojullien@users.noreply.github.com>

* fixed issue #8

Signed-off-by: ojullien <ojullien@users.noreply.github.com>

* reverseproxy refactoring

Signed-off-by: ojullien <ojullien@users.noreply.github.com>

* reverseproxy refactoring

Signed-off-by: ojullien <ojullien@users.noreply.github.com>

* reverseproxy refactoring

Signed-off-by: ojullien <ojullien@users.noreply.github.com>

* update proxy directive
ojullien added a commit that referenced this issue Aug 8, 2019
@ojullien
Fixes issues #7 and #8. Merge pull request #9 and #10
d883e4d
@ojullien
Copy link
Owner Author

ojullien commented Feb 4, 2020 •
edited
Loading

The HTTP page still sends an HSTS header.

The HSTS directive is still in the conf-available/zzz-ssl.conf file.

@ojullien ojullien reopened this Feb 4, 2020
@ojullien ojullien added the invalid This doesn't seem right label Feb 4, 2020
@ojullien
Copy link
Owner Author

ojullien commented Feb 4, 2020

My mistake, checking wrong version.

@ojullien ojullien closed this as completed Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ojullien ojullien

Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Milestone
v1.3.x
Development

No branches or pull requests
1 participant
@ojullien