Clean up and refactor #2

pdelboca · 2022-09-27T09:35:42Z

This PR cleans a little bit the code and uses more up-to-date CKAN practices in syntax and naming conventions.

Run tests on PRs
Imports directly toolkit instead of calling p.toolkit
Tidy the imports
Some pep8 fixes
Clean some code used for compatibility with old versions
Create a custom render_jinja2 method to render body emails without depending on a request context
Replace deprecated h.truncate() method
Reduces dependency of g object in templates. (Using render's extra_vars)
It also adds support for CKAN 2.10. (Tests are failing due to this bug Fix CKAN registering only plugin's first blueprint ckan/ckan#7108)

pdelboca added 28 commits September 27, 2022 11:08

Cleanup plugin.py file

457b9a0

Update CI to run tests o PR

9c075f0

Cleanup test files

59acd48

Clean not accessed variable

10ec17d

Clean action module imports

053836d

Clean helpers.py

7a0ebdd

Clean auth.py

6b779ec

Do not use path in ckan_extends tag

f27c876

Add mock to dev-requirements.txt

90aed25

Restore imports

18a074e

Use custom render for email bodies

4f82974

Replace deprecated helper

c4aba04

Refactor removed jinja_extensions.Environemnt attribute

794018f

Register actions explicitly

089e10b

Clean and sort imports

d5e1a2b

Use toolkit instead of direct ckan.logic calls

d4db336

Delete TO DELETE code

00bfd26

Minor pep8 fixes

81827c8

Clean unused import

52a5761

Fix pep8

5888ee2

Do not use g object in add.html template

5003093

Drop CKAN 2.8 support on template

e2a6cf2

Fix pep8

9e3443f

Some pep8 fixes

e86b8f0

Reduce usage of g object in template

ca839a1

Simplify query (and compatibility 2.10)

81fb364

Replace deprecated attribute

16825e1

Update docs

b611583

pdelboca merged commit 6491add into master Sep 29, 2022

Provide feedback