Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover development flow (tests/CI); remove lxml dependency (via pyquery) #312

Merged
merged 5 commits into from
Apr 11, 2024

Conversation

roll
Copy link
Collaborator

@roll roll commented Apr 9, 2024


Please make sure that all the checks pass. Please add here any additional information regarding this pull request. It's highly recommended that you link this PR to an issue (please create one if it doesn't exist for this PR)

@roll roll changed the title Remove lxml dependency Remove lxml dependency (via pyquery) Apr 9, 2024
@roll roll force-pushed the 303/remove-lxml-dependency branch from b629e47 to deca91b Compare April 9, 2024 14:31
Copy link

cloudflare-workers-and-pages bot commented Apr 9, 2024

Deploying opendataeditor with  Cloudflare Pages  Cloudflare Pages

Latest commit: deca91b
Status: ✅  Deploy successful!
Preview URL: https://d2c7be53.opendataeditor.pages.dev
Branch Preview URL: https://303-remove-lxml-dependency.opendataeditor.pages.dev

View logs

@roll roll changed the title Remove lxml dependency (via pyquery) Recover development flow (tests/CI) Apr 9, 2024
@roll roll force-pushed the 303/remove-lxml-dependency branch from d1b536a to deca91b Compare April 9, 2024 14:40
@roll roll changed the title Recover development flow (tests/CI) Recover development flow (tests/CI); remove lxml dependency (via pyquery) Apr 9, 2024
@roll roll requested review from pdelboca and romicolman April 9, 2024 14:41
@roll
Copy link
Collaborator Author

roll commented Apr 9, 2024

Hey @pdelboca @romicolman
Aside from the CI/tests fixes needed for recovering development flow, this PRs remove pyquery dependency that causes lxml installation from #303. In general, the lxml dependency is very slow to install, and it seems to it just doesn't work on some MacOS versions (it can't be fixed on our side). So we can just drop tabular HTML format support for now as it's actually never been documented and does not really have any UI support. Moreover, HTML has never been mentioned during the User Research phase as a tabular format.

@pdelboca pdelboca merged commit 6ec7038 into main Apr 11, 2024
9 checks passed
@pdelboca pdelboca deleted the 303/remove-lxml-dependency branch April 11, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on launch / update
2 participants