Make build in CI for Mac 13, not for latest #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guergana
changed the title
Deploying opendataeditor with
|
| Latest commit: |
305e36d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dc3e8ebb.opendataeditor.pages.dev |
| Branch Preview URL: | https://build-for-mac-14.opendataeditor.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been reported that the built version is not running in older versions of Mac. I have created this PR to target version 13 in mac for the generated build in CI to see if this solves the issue.
@roll we have created this PR to address the issue that the app is not installing in mac versions 14+, I have made a build for mac-13 that has been tested in
mac-13andmac-14and installs the app successfully. (Tested by @Faithkenny and @romicolman manually).The possible explanation can be found on this thread:
I would suggest that we target macos-13 for now as our build version until we solve the certificate issue. And anyway targetting the latest version is not the best idea, we need to target older versions as well.