Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed default_method to "temporary" #16

Merged
merged 1 commit into from
Mar 16, 2015
Merged

Conversation

aramk
Copy link
Contributor

@aramk aramk commented Mar 1, 2015

This fixes #15. I figured out what it was. I'm generating a lot of session variables with randomized UUID names. This is fine since on refresh they're cleared and have no impact. The issue is that persistent-session has the following line:

var default_method = 'persistent';

According to the docs, this should be set to temporary. At the moment, all calls to Session.set() will be storing the value in the persistent session which I believe is unintended.

@pauldowman
Copy link
Member

Thanks! This also fixes #14. Note to @rgould to update the major version number since it's a breaking change.

@rgould rgould merged commit df73869 into okgrow:master Mar 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite loop during app startup
3 participants