Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ci/shellcheck #4

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Ci/shellcheck #4

merged 3 commits into from
Oct 6, 2023

Conversation

ccamel
Copy link
Member

@ccamel ccamel commented Oct 5, 2023 •
edited
Loading

This PR adds the ShellCheck linter to the CI to enhance the code quality and maintainability of all the Shell scripts of the project.

Equivalent to:

find . -name "*.sh" -exec shellcheck {}  -x -e SC2002 \;

@ccamel ccamel self-assigned this Oct 5, 2023
@ccamel ccamel marked this pull request as ready for review October 5, 2023 10:13
antho31
antho31 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@antho31 antho31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thanks!

bdeneux
bdeneux approved these changes Oct 5, 2023
View reviewed changes
Copy link

@bdeneux bdeneux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@ccamel ccamel merged commit af10909 into main Oct 6, 2023
7 checks passed
@ccamel ccamel deleted the ci/shellcheck branch October 6, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antho31 antho31 antho31 approved these changes

@bdeneux bdeneux bdeneux approved these changes

@amimart amimart Awaiting requested review from amimart

Assignees

@ccamel ccamel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ccamel @antho31 @bdeneux