Enhancement/wrobe0709/list unenrolled submissions #1128
Conversation
server/controllers/admin.py
Outdated
| courses, current_course = get_courses(cid) | ||
|
|
||
| submissions = set(b.submitter_id for b in (Backup.query.join(Backup.assignment).filter(Assignment.course_id == cid).all())) | ||
| enrollment = set(e.user_id for e in (Enrollment.query.filter(Enrollment.course_id == cid).all())) |
There was a problem hiding this comment.
These two lines are a bit too long. I would suggest putting the queries on their own lines
There was a problem hiding this comment.
Maybe you can use course.get_students here? It also does a joined load with Users - so you can just do e.user without the cost of another query
server/controllers/admin.py
Outdated
|
|
||
| for s in submissions: | ||
| if s not in enrollment: | ||
| unenrolled_submitters.append(User.query.get(s)) |
There was a problem hiding this comment.
See above - you should be able to do e.user if you use enrollment objects directly
| {{ unenrolled_submitter.email }} | ||
| </a> | ||
| </td> | ||
| <td class="sid">{{ unenrolled_submitter.id }}</td> |
There was a problem hiding this comment.
The ID isn't particularly useful (it's our database ID) Maybe their name could go here instead?
|
I'm pulling in staff and lab assistants because I was getting them in the list of un-enrolled submitters. I'm assuming we don't want them in that list and that we just want students? Because I can get the user objects from |
Fixes #1070
If a student is not enrolled in a class but submitting assignments for the class their submissions won't be seen by the staff.
This adds a view called "Un-Enrolled Submitters" which allows staff members to see any students who are submitting assignments to the course but are not enrolled.