feat: support role based auth directive - OKTA-277249 #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const value = groups[key]; | ||
|
|
||
| // groups or custom claims is avaiable in idToken | ||
| if (idToken.claims[key]) { |
There was a problem hiding this comment.
Would verifying ID token before checking the claims be useful for this feature?
There was a problem hiding this comment.
It's checked at the beginning of this method. around line 39
oleksandrpravosudko-okta
approved these changes
Sep 27, 2021
mraible
reviewed
Sep 27, 2021
src/okta/has-any-group.directive.ts
Outdated
| @Input() set oktaHasAnyGroup(groups: Groups) { | ||
| this.authStateService.hasAnyGroups(groups) | ||
| .subscribe(isAuthorized => { | ||
| // not update UI if no state change |
There was a problem hiding this comment.
Suggested change
| // not update UI if no state change | |
| // don't update UI if no state change |
mraible
reviewed
Sep 27, 2021
| const key = Object.keys(groups)[0]; | ||
| const value = groups[key]; | ||
|
|
||
| // groups or custom claims is avaiable in idToken |
There was a problem hiding this comment.
Suggested change
| // groups or custom claims is avaiable in idToken | |
| // groups or custom claims is available in idToken |
shuowu-okta
force-pushed
the
sw-role-based-auth-directive-new-OKTA-277249
branch
from
1834a11
to
f4b6860
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Reviewers