Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sdk compatibility issue with old version of angular #74

Closed
wants to merge 2 commits into from
Closed

fix: sdk compatibility issue with old version of angular #74

wants to merge 2 commits into from

Conversation

shuowu
Copy link
Contributor

@shuowu shuowu commented Nov 3, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Adding Tests
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

Issue Number: OKTA-435165

What is the new behavior?

Use angular v7 to build okta-angular SDK, so the generated types can compatible with all supported angular versions in README.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Reviewers

@shuowu-okta shuowu-okta force-pushed the sw-fix-angular-compatibility-issue-OKTA-435165 branch from 9d391e9 to d00a8ac Compare November 4, 2021 15:11
eng-prod-CI-bot-okta pushed a commit that referenced this pull request Nov 4, 2021
@shuowu @eng-prod-CI-bot-okta
fix: sdk compatibility issue with old version of angular
9b17291 
OKTA-435165
<<<Jenkins Check-In of Tested SHA: 9752180 for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-angular
Files changed count: 10
PR Link: "#74"
eng-prod-CI-bot-okta pushed a commit that referenced this pull request Nov 4, 2021
@shuowu @eng-prod-CI-bot-okta
update version to 4.1.1
9f236d6 
OKTA-435165
<<<Jenkins Check-In of Tested SHA: 9752180 for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-angular
Files changed count: 10
PR Link: "#74"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredperreault-okta jaredperreault-okta jaredperreault-okta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shuowu @jaredperreault-okta @eng-prod-CI-bot-okta