Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unecessary local input validation using ValidateDiagFunc #1513

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

monde
Copy link
Collaborator

@monde monde commented Mar 29, 2023

Let Okta API validate input, don't do it artificially with TF SDK ValidateDiagFunc's. Run gofumpt -w -extra .

Ref: OKTA-532544

On MAX org

 ± grep -h "^... \(PASS\|FAIL\|SKIP\): " /tmp/testacc.log |  awk '{ print $2}' | sort | uniq --count
  16 FAIL:
 213 PASS:
  29 SKIP:

`ValidateDiagFunc`'s. Run `gofumpt -w -extra .`

Ref: OKTA-532544
@monde monde marked this pull request as draft March 29, 2023 18:44
@monde monde marked this pull request as ready for review March 29, 2023 19:42
@monde monde merged commit 4b2190b into v4.0.0 Mar 29, 2023
@ktham
Copy link

ktham commented May 2, 2023

@monde It's good that we have the API handle the validation to avoid duplication of logic and maintaining that logic in 2 places, but will the validation still happen during terraform "plan" time? I hope it doesn't wait until "apply" time before validations kick in... that would be an undesired regression imho as a user of the okta provider.

@ktham ktham mentioned this pull request May 3, 2023
@duytiennguyen-okta duytiennguyen-okta deleted the remove_artificial_validators branch May 4, 2023 14:54
@monde
Copy link
Collaborator Author

monde commented May 4, 2023

@ktham - @duytiennguyen-okta @jefftayor-okta and I going to take a second look at this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants