Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge cosmos sdk pr for performance.(6811,10339,8811) #2100

Merged
merged 4 commits into from
May 26, 2022

Conversation

zjg555543
Copy link
Contributor

  • merge cosmos sdk pr #6811 and #10339,fix for removeZeroCoins mutates original slice;
  • merge cosmos sdk pr #8811, use typed types/kv.List instead of container/list.List
  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

…iginal slice;merge cosmos sdk pr 8811, use typed types/kv.List instead of container/list.List
@codecov-commenter
Copy link

codecov-commenter commented May 25, 2022

Codecov Report

Merging #2100 (c372f05) into dev (dff85df) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #2100   +/-   ##
=======================================
  Coverage   49.47%   49.47%           
=======================================
  Files         280      280           
  Lines       20819    20819           
=======================================
  Hits        10301    10301           
  Misses       9738     9738           
  Partials      780      780           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@zjg555543 zjg555543 requested a review from KamiD May 25, 2022 05:12
@zjg555543 zjg555543 marked this pull request as ready for review May 25, 2022 05:17
@KamiD KamiD marked this pull request as draft May 25, 2022 05:24
@zjg555543 zjg555543 requested a review from cwbhhjl May 25, 2022 05:59
@zjg555543 zjg555543 marked this pull request as ready for review May 25, 2022 07:43
@KamiD KamiD marked this pull request as draft May 25, 2022 09:59
@KamiD KamiD marked this pull request as ready for review May 26, 2022 01:14
@KamiD KamiD merged commit 48f7205 into dev May 26, 2022
@KamiD KamiD deleted the zjg/issue-1427-merge-cosmos-pr branch May 26, 2022 01:15
@KamiD KamiD restored the zjg/issue-1427-merge-cosmos-pr branch May 26, 2022 23:19
@zjg555543 zjg555543 deleted the zjg/issue-1427-merge-cosmos-pr branch May 30, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants