Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pgu #151

Merged
merged 4 commits into from
May 31, 2023
Merged

update pgu #151

merged 4 commits into from
May 31, 2023

Conversation

yann-sjtu
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2023

Codecov Report

Merging #151 (8e2f55d) into dev (23e9141) will decrease coverage by 0.01%.
The diff coverage is 30.00%.

❗ Current head 8e2f55d differs from pull request most recent head d60d230. Consider uploading reports for the commit d60d230 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev     #151      +/-   ##
==========================================
- Coverage   34.23%   34.23%   -0.01%     
==========================================
  Files         423      423              
  Lines       44287    44317      +30     
==========================================
+ Hits        15163    15172       +9     
- Misses      28025    28046      +21     
  Partials     1099     1099              
Impacted Files Coverage Δ
app/config/config.go 26.94% <30.00%> (+0.15%) ⬆️

@yann-sjtu yann-sjtu force-pushed the yxq/update-pgu branch 2 times, most recently from f21e75a to 950a8db Compare May 28, 2023 06:30
@KamiD KamiD merged commit 1b5fc9e into dev May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants