Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtx putType data use store #157

Merged
merged 6 commits into from
Jun 1, 2023
Merged

runtx putType data use store #157

merged 6 commits into from
Jun 1, 2023

Conversation

chengzhinei
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@chengzhinei chengzhinei marked this pull request as ready for review June 1, 2023 07:02
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2023

Codecov Report

Merging #157 (4127554) into dev (9c0b8c0) will increase coverage by 0.00%.
The diff coverage is 53.84%.

❗ Current head 4127554 differs from pull request most recent head 6024a41. Consider uploading reports for the commit 6024a41 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##              dev     #157   +/-   ##
=======================================
  Coverage   34.22%   34.22%           
=======================================
  Files         423      423           
  Lines       44331    44348   +17     
=======================================
+ Hits        15173    15180    +7     
- Misses      28057    28066    +9     
- Partials     1101     1102    +1     
Impacted Files Coverage Δ
x/evm/keeper/keeper.go 53.14% <11.11%> (-2.70%) ⬇️
x/evm/types/statedb.go 71.82% <60.00%> (-0.22%) ⬇️
x/evm/keeper/keeper_mpt.go 52.38% <100.00%> (+7.38%) ⬆️
x/evm/types/statedb_mpt.go 53.26% <100.00%> (+2.12%) ⬆️

@KamiD KamiD merged commit d376415 into dev Jun 1, 2023
@KamiD KamiD deleted the fsc/runtx-store branch June 1, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants