Merge dev into upstream v0.2.1
#8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-estimation option to avoid gas estimationi
* add linters * fix: lint fix * fix: lint make file * feat: sonar * fix: remove unused files * try to include coverage * fix: change sonar cloud project key * small fix * fix: comments --------- Co-authored-by: Rachit Sonthalia <rachitsonthalia02@gmail.com>
* ensure tx order * fix: linter
* Serial nonce update (0xPolygon#74) * feat: prepare txns before routines * fix: remove forcedNonce feature * feat: uts * fix: lint * lint fix --------- Co-authored-by: Goran Rojovic <100121253+goran-ethernal@users.noreply.github.com> Co-authored-by: Goran Rojovic <goran.rojovic@ethernal.tech>
* feat: initial scaffolding * feat: insert implementation * feat: change column types based on the SQL lite supported types * feat: changed schema, first version of CRUD operations implementation * refactor: extract common parts to helper functions * chore: add comments * fix: linter config warning * refactor: simplify in-memory storage and fix deadlocks in case of errors * feat: instantiate either in memory or sql storage * chore: add comment * test: fully covered memstorage feat minor renames * feat: add github.com/mattn/go-sqlite3 as direct dependency * fix: adapt the DB schema, fix issues and add unit tests for sql storage * feat: increase coverage * test: add some more unit tests * fix: group variables * refactor: rename PersistenceFilename config parameter * fix: rename helper function (address comment part 1) * feat: introduce meddler * chore: remove useless comments * fix: revert update logic to manually constructing SQL and address comments from @joanestebanr (part 1) * fix: change some columns types (address comment from @joanestebanr 2nd part) * fix: use meddler to construct on fly update statement, address comments from @joanestebanr (part 3) * feat: remove in memory storage, change block_number to BIGINT (address @joanestebanr part 4) * fix: remove redundant code * feat: simplify building of UPDATE clause * rebase fix * refactor: build base select and base delete statement dynamically (address comment from @arnaubennassar) * test: concurrent write to the database unit test --------- Co-authored-by: Goran Rojovic <goran.rojovic@ethernal.tech>
* fix * comment
Vui-Chee
commented
Nov 14, 2024
There was a problem hiding this comment.
Added by v0.2.1 0xPolygon/zkevm-ethtx-manager.
Vui-Chee
commented
Nov 14, 2024
There was a problem hiding this comment.
Added by v0.2.1 0xPolygon/zkevm-ethtx-manager.
Vui-Chee
commented
Nov 14, 2024
There was a problem hiding this comment.
Moved to types/interfaces.go folder in v0.2.1 0xPolygon/zkevm-ethtx-manager.
Vui-Chee
commented
Nov 14, 2024
There was a problem hiding this comment.
Removed in v0.2.1 0xPolygon/zkevm-ethtx-manager.
Vui-Chee
commented
Nov 14, 2024
There was a problem hiding this comment.
Moved to types/interfaces.go folder in v0.2.1 0xPolygon/zkevm-ethtx-manager.
Vui-Chee
commented
Nov 14, 2024
There was a problem hiding this comment.
Moved to types/interfaces.go folder in v0.2.1 0xPolygon/zkevm-ethtx-manager.
author Vui-Chee <vuicheesiew@gmail.com> 1731548943 +0800 committer Vui-Chee <vuicheesiew@gmail.com> 1731548943 +0800 parent 1b8de9d author Vui-Chee <vuicheesiew@gmail.com> 1731476344 +0800 committer Vui-Chee <vuicheesiew@gmail.com> 1731548582 +0800 Merge `dev` into upstream v0.2.1 Fix lint errs Comment interface method Fix configure (#3) * fix configure * keep the same with genesis Silence sonar cloud go mod tidy Add back hex ut to keep consistent with `dev`
Vui-Chee
force-pushed
the
vui-chee/base-dev-v0.2.1
branch
from
ea372f0 to
700f184
Compare
zjg555543
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares this repo as a dependency for the new CDK. It combines custodial assets logic with v0.2.1 updates in the upstream https://github.com/0xPolygon/zkevm-ethtx-manager/tree/v0.2.1. Once merged, a new tag
v0.2.1will be assigned and referenced from the new CDK repo.For context, xlayer-node use to contain ethtxmanager code, however, the powers that be decided to split ethtxmanager code into a separate repo as a dependency, which invariably led to this PR.
In an effort to make future updates as seamless as possible, most of the new changes are preserved and custom changes are pushed to separate new files.
Change list
"github.com/0xPolygonHermez/zkevm-ethtx-manager"=>"github.com/0xPolygon/zkevm-ethtx-manager"fromaddress) for ethtxmanager in separate filexlayer_ethtxmanager.gomonitoredTx=>zkmanTypes.MonitoredTx(types file is moved)hex.gounder hex folder (these file is extracted from CDK repo)GetZkEVMAddressAndL1ChainID()method toEthermanInterfaceGetZkEVMAddressAndL1ChainID)