Flags #15
Merged
Flags #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wip Fix bad command index, remove tmp_dir
gkousik
reviewed
Apr 26, 2019
There was a problem hiding this comment.
- Did you test local fallback after these flag changes? Does execvp() still work as expected?
- I think merge of this change should be co-ordinated with changes to ninja and our scripts? If so can we merge it on Monday and all of us update our tools at the same time?
Otherwise, the changes itself LGTM.
|
ola-rozenfeld
approved these changes
Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a CLI to rbecc, avoiding the use of environment variables as flags.