-
Notifications
You must be signed in to change notification settings - Fork 863
Gutenberg ? #1301
Comments
The short answer to your question is that FoundationPress as-is doesn't take advantage of Gutenberg, but theme developers using it absolutely can add code to do so. I certainly don't see FoundationPress themes breaking with Gutenberg. Trying Gutenberg out on an unmodified FoundationPress package without any other plugins works fine, except extra wide image blocks (CSS classes There is this article that individual theme developers could reference: I don't know much about it, maybe a positive step would be adding a way for FoundationPress to generate a gutenberg editor CSS file - perhaps automatically from the default stylesheet while providing gutenberg overrides for classes that break the editor. |
It might be interesting to implement custom blocks for the category layout to provide the grid system of foundation, especially when block nesting gets possible in Gutenberg (Gutenberg Issue #428). |
Nothing is breaking but I think we should add styling for the new Gutenberg Blocks (like the buttons)
The sidebar layout is not made for the fullwidth elements.
That's not as easy as generating the css for the TinyMCE Editor. Currently we are loading the whole app.css into the TinyMCE Editor. Unfortunately that's not possible with the Gutenberg Editor. The gutenberg editor needs a separate stylesheet, with only the relevant styles to ensure the css only applies to the editor (not the WP backend menu, metaboxes…). This means the gulp tasks and the css/sass file structures must be adjusted. I'm not sure about the best way to do this. Maybe we should wait and watch how the WordPress default themes do it. |
I have been a bit more busy at this topic.
These adjustements are not mandatory to support the Gutenberg Editor. FoundationPress is already supporting the Gutenberg Editor. But even if nothin is breaking in the new editor there ist still room for improvements to provide a perfect user experience in the Gutenberg Editor when FoundationPress |
I already started with these adjustments https://github.com/derweili/FoundationPress/tree/gutenberg @olefredrik @colin-marshall what are your thoughts on this? |
I continued to extend the FoundationPress Theme to fully support the Gutenberg Editor. To add styles to the Gutenberg Editor I added a separate editor.scss and added this file to the build process. Additionaliy to the editor.scss I added a gutenberg.php which is included into the function php. To add styling for the Gutenberg blocks in the frontend, I added gutenberg.scss file where all the blocks are styled. |
Ohoy! Great job @derweili 🎉 Awesome stuff! |
How do you import local fonts using this structure? I can easily do Google fonts. I've tried referencing in the editor.scss file but I have to provide a relative path all the way back to wp-content and then get errors in the wp-tinymce.js file. Currently my fonts are outputted in the dist/fonts folder I have created. |
With Gutenberg getting closer to being released, I have to confess I need to do a lot more reading up on it. But is there anything that needs to change with foundationpress to fully support it?
The text was updated successfully, but these errors were encountered: