Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrency control for hosted scripts needs to be system wide #56

Closed
oleg-shilo opened this issue Mar 22, 2017 · 5 comments
Closed

Concurrency control for hosted scripts needs to be system wide #56

oleg-shilo opened this issue Mar 22, 2017 · 5 comments

Comments

@oleg-shilo
Copy link
Owner

Triggered by #50 (Issue 3)


CSScript.GetCompilerLockName() should use system wide Mutex based on source/compiled script location. Currently it is based on combination of Process.ID and script location.

@oleg-shilo
Copy link
Owner Author

Fixed in v3.25.1: https://github.com/oleg-shilo/cs-script/releases/tag/v3.25.1.0

Now concurrency of hosted execution is controlled by CSScript.HostingConcurrencyControl, which is set by default to system wide synchronization for a given script file.

@maettu-this
Copy link
Collaborator

I'm a bit confused as the release notes of v3.25.1 don't mention anything about #56.

I'll wait until tomorrow and then try v3.25.1 and comment here and #50 with my findings.

@oleg-shilo
Copy link
Owner Author

The release note was inaccurate. Corrected now.

@maettu-this
Copy link
Collaborator

I confirm that running the same script in parallel instances of my hosting application now perfectly works :-) Once more, thanks for fixing! Also thanks for confirmation and correction of the release notes.

By the way, there's a "\Source\ReleaseNotes.txt" which I think is obsolete, as it only covers information up to v3.8.8.1.

So, as far as I can tell, this #56 as well as 'Issue 3' of #50 have been resolved :-)

@oleg-shilo
Copy link
Owner Author

Thank you, closing it now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants