Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DigitalSignatureBootstrapper does not pass through UseCertificatesStore parameter #251

Closed
ghost opened this issue Dec 22, 2017 · 0 comments
Closed

DigitalSignatureBootstrapper does not pass through UseCertificatesStore parameter #251

ghost opened this issue Dec 22, 2017 · 0 comments

Comments

@ghost
Copy link

ghost commented Dec 22, 2017 

var digitalSignatureBootstrapper = new DigitalSignatureBootstrapper
            {
                PfxFilePath = "MyCert",
                TimeUrl = new Uri("http://timestamp.digicert.com"),
                UseCertificateStore = true,
                OptionalArguments = "/fd sha256"
            };

On Apply call, UseCertificateStore isn't propagated to CommonTasks.Tasks.DigitalySignBootstrapper which causes a file not found exception on the certificate file due to only the friendly name being provided to /f instead of /n in CommonTasks.Tasks.DigitiallySign
@ghost ghost mentioned this issue Dec 22, 2017
Merged
oleg-shilo added a commit that referenced this issue Jan 12, 2018
@oleg-shilo
Release v1.6.0.0
81f327f 
----
* Migration of WixSharp types to IGenericEntity model:
	* Rework Certificate using IGenericEntity
	* Rework SqlDatabase, SqlString and SqlScript using IGenericEntity
	* Rework DriverInstaller using IGenericEntity
	* Rework FirewallException using IGenericEntity
	* Rework EnvironmentVariable using IGenericEntity
	* Rework FirewallException using IGenericEntity
	* Rework User using IGenericEntity
	* Rework IniFile using IGenericEntity

* Added support for new WiX types:
	* CloseAppplication
	* RemoveRegistryKey

* Defect fixes:
	* Issue #258: WixSharp doesn't remove temporary files if custom output name is specified
	* Issue #251: Passing UseCertificateStore parameter from DigitalSignatureBootstrapper
	* Issue #247: Handling null TimeUrl
	* Issue #251: Passing UseCertificateStore parameter from DigitalSignatureBootstrapper through to DigitallySign
	* Issue #233: FileSearch
	* Issue #230: CustomAction Condition extension
	* Issue #226: Project.HashedTargetPathIdAlgorithm generates invalid ids

* Various improvements and minor fixes:
	* Fixed the problem with EnvironmentVariable not having XML parent when it is hosted by the component-less WiX (e.g. ConsumingMergeModule sample).
	* CustomAction.UsesProperties & .RollbackArgs space trimming
	* Trim all spaces around properties (name and value) before passing to msi
	* CommonTasks.InstallService fix & new overload
	* Fixed installService args location, added overload that accepts username and password
	* Added `WixObject.MapComponentToFeatures` to assist with implementation of IGenericEntity based WiX objects.
	* fix "CustomActionRef.When" property handling in compile.
	* change to use just WixSharp.When.ToString()
	* fix CustomActionRef will add "Before" attribute in Custom Element even if set When.After
	* Added extension methods for
	  - `Project.Add(IGenericEntity[])`
	  - `File.Add(IGenericEntity[])`
	  - `Dir.Add(IGenericEntity[])`

* AppVeyor integration (https://ci.appveyor.com/project/oleg-shilo/wixsharp)
oleg-shilo added a commit that referenced this issue Jan 12, 2018
@oleg-shilo
Release v1.6.0.0
a84d369 
----
* Migration of WixSharp types to IGenericEntity model:
    * Rework Certificate using IGenericEntity
    * Rework SqlDatabase, SqlString and SqlScript using IGenericEntity
    * Rework DriverInstaller using IGenericEntity
    * Rework FirewallException using IGenericEntity
    * Rework EnvironmentVariable using IGenericEntity
    * Rework FirewallException using IGenericEntity
    * Rework User using IGenericEntity
    * Rework IniFile using IGenericEntity

* Added support for new WiX types:
    * CloseAppplication
    * RemoveRegistryKey

* Defect fixes:
    * Issue #258: WixSharp doesn't remove temporary files if custom output name is specified
    * Issue #251: Passing UseCertificateStore parameter from DigitalSignatureBootstrapper
    * Issue #247: Handling null TimeUrl
    * Issue #251: Passing UseCertificateStore parameter from DigitalSignatureBootstrapper through to DigitallySign
    * Issue #233: FileSearch
    * Issue #230: CustomAction Condition extension
    * Issue #226: Project.HashedTargetPathIdAlgorithm generates invalid ids

* Various improvements and minor fixes:
    * Fixed the problem with EnvironmentVariable not having XML parent when it is hosted by the component-less WiX (e.g. ConsumingMergeModule sample).
    * CustomAction.UsesProperties & .RollbackArgs space trimming
    * Trim all spaces around properties (name and value) before passing to msi
    * CommonTasks.InstallService fix & new overload
    * Fixed installService args location, added overload that accepts username and password
    * Added `WixObject.MapComponentToFeatures` to assist with implementation of IGenericEntity based WiX objects.
    * fix "CustomActionRef.When" property handling in compile.
    * change to use just WixSharp.When.ToString()
    * fix CustomActionRef will add "Before" attribute in Custom Element even if set When.After
    * Added extension methods for
      - `Project.Add(IGenericEntity[])`
      - `File.Add(IGenericEntity[])`
      - `Dir.Add(IGenericEntity[])`

* AppVeyor integration (https://ci.appveyor.com/project/oleg-shilo/wixsharp)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants