-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Certificate password can be null #387
Comments
You are absolutely right. I was not aware that password is optional. Do you need a HotFix release or you prefer to wait for the normal release? |
I am hitting the same issue, tried to solve it with password=string.Empty but for some reason it does not work. Thanks |
I can wait for the normal release. |
* Issue #387: Certificate password can be null
Done:
|
PM> Install-Package WixSharp -Version 1.6.5.2-HotFix Attempting to gather dependency information for package 'WixSharp.1.6.5.2-HotFix'
|
Give it another try. May be NuGet was not ready yet. The package is there: https://www.nuget.org/packages/WixSharp/1.6.5.2-HotFix |
yes but shouldn't the dependency in WixSharp.nuspec also point to 1.6.5.2-HotFix instead of this?
edit: since WixSharp.bin 1.6.5.2 does not actually exists (only WixSharp.bin 1.6.5.2-Hotfix, as the error message states) |
:( Yes . My mistake. |
Should be OK now
|
* Implemented NSIS-based bootstrapper. * Issue #387: Certificate password can be null * Issue #377: How to register a new MIME type with custom document icon * Issue #373: Bootstrapper.DigitalSignature.Apply hide console output * Added missing IconFile support * SetupEvent sample extended to show how restart itself elevated if required.
Hi Oleg,
with commit 281567b an
ArgumentNullException
is thrown using the following code:The
password
variable can benull
.wixsharp/Source/src/WixSharp/CommonTasks.cs
Line 215 in 90111a5
The text was updated successfully, but these errors were encountered: