NHibernate.dll in Custom Actions

[NikGovorov]

Hi Oleg,

I have an issue packing NHibernate.dll to *.CA.dll, it's packed just as NHibernate(without dll extension). I assume we loose the file extension on the following line:

wixsharp/Source/src/WixSharp/ProjectValidator.cs

Line 225 in 46758d2

return IO.Path.Combine(dir, asm.ManifestModule.ScopeName);

. Probably it happens because NHibernate is ilmerged. The only workarounds I see now are run-time ones: custom assembly resolver, assemblyBinding/dependentAssembly/codeBase section in CustomAction.config or even just rename 'NHibernate' file to 'NHibernate .dll' before executing a custom action.

Thoughts?

[oleg-shilo]

It's a defect. Will look at it.
As a temp work around indeed AppDomain assembly resolver seems to be the most practical approach.

[oleg-shilo]

Fixed (commit a248dd6). The fix will be available with the very next release. There are some pull requests to be released so I will be making a release early next week.

Thank you for reporting the defect.

[NikGovorov]

Great job, thanks!